Commit graph

1064 commits

Author SHA1 Message Date
Malte Rosenbjerg
9b1e373c55
Merge pull request #593 from snechaev/PR-592_Snapshot_Cancellation_Support
Add cancellation token support for the [Gif]SnapshotAsync
2025-10-27 20:12:53 +01:00
Malte Rosenbjerg
935e1cf17c
Merge branch 'main' into PR-592_Snapshot_Cancellation_Support 2025-10-27 19:56:10 +01:00
Malte Rosenbjerg
d916fd3be4 Update nuget details 2025-10-27 19:53:39 +01:00
Malte Rosenbjerg
dbf672fd6a
Merge pull request #597 from rosenbjerg/improve-tests-usage-of-cancellation-token
Improve tests usage of cancellation token
2025-10-27 19:47:19 +01:00
Malte Rosenbjerg
3c8d2c23c1 Use using for CancellationTokenSource 2025-10-27 19:39:13 +01:00
Malte Rosenbjerg
919c6ef526 Use CreateLinkedTokenSource to bind to TestContext cancellationtoken 2025-10-27 19:38:58 +01:00
Malte Rosenbjerg
1346049991
Merge pull request #595 from snechaev/PR-594_Fix_Unexpected_FFMpegException_On_Cancellation
Do not throw unexpected FFMpegException on FFProbe cancallation. Fixes  #594
2025-10-27 19:15:11 +01:00
Sergey Nechaev
67af2aa01d Move cancellation check outside of the ThrowIfExitCodeNotZero() and call it separately in all the async code paths. 2025-10-27 13:36:42 +01:00
Sergey Nechaev
560c791802 Update the ThrowIfExitCodeNotZero() to check the exit code before handling cancellation.
This preserves the original semantics and contract (throw only if the ffprobe exits with a non-zero code).
2025-10-27 13:30:59 +01:00
Sergey Nechaev
e44611bd25 Additional test to verify that FFProbeHelper still throws FFMpegException when FFProbe exits with non-zero code and no cancellation was requested.
Ref.: #594
2025-10-27 13:30:59 +01:00
Sergey Nechaev
b863f5d19e FFProbe: Do not throw FFMpegException if cancellation was requested.
Throw OperationCancelledException in this case to provide more uniform and expected behavior.

Fixes #594
2025-10-27 13:30:59 +01:00
Sergey Nechaev
930d493b8c Add test to verify unexpected exception on FFProbe operations cancellation.
Ref.: #594
2025-10-27 13:30:59 +01:00
Malte Rosenbjerg
2f06ec99f3
Merge pull request #596 from rosenbjerg/add-metadata-builder-class
Add metadata builder class
2025-10-25 11:55:52 +02:00
Malte Rosenbjerg
53445322e4 Fix linting 2025-10-25 11:36:40 +02:00
Malte Rosenbjerg
15acd9f0da Add BOM 2025-10-25 11:28:47 +02:00
Malte Rosenbjerg
ef313ea411 Add test verifying functionality 2025-10-25 11:25:52 +02:00
Malte Rosenbjerg
62e829d9b4 Add AddMetaData overload accepting FFMetadataBuilder instance 2025-10-25 11:25:43 +02:00
Malte Rosenbjerg
97053929a9 Add FFMetadataBuilder for easily constructing metadata text 2025-10-25 11:25:16 +02:00
Sergey Nechaev
f5ecbaee68 Fixed a race condition that occurred when handling the cancellation of an asynchronous operation after the FFmpeg process had already exited. Fixes #348.
Related: #592
2025-10-22 16:13:38 +02:00
Sergey Nechaev
b3c201b42e Add cancellation token support to SnapshotAsync, GifSnapshotAsync and SubVideoAsync methods. Fixes #592. 2025-10-21 17:25:51 +02:00
Malte Rosenbjerg
a599c48511
Merge pull request #585 from rosenbjerg/fix-fps-handling-in-join-image-sequence
Fix fps handling in JoinImageSequence
2025-10-18 01:04:10 +02:00
Malte Rosenbjerg
0e62fb4d57
Merge branch 'main' into fix-fps-handling-in-join-image-sequence 2025-10-18 00:37:20 +02:00
Malte Rosenbjerg
4db4d2c8ea
Merge pull request #586 from rosenbjerg/improve-percentage-progress-test
Improve test for percentage progress events
2025-10-18 00:36:19 +02:00
Malte Rosenbjerg
f20bd0c433
Merge branch 'main' into improve-percentage-progress-test 2025-10-18 00:01:33 +02:00
Malte Rosenbjerg
7d4545ffe0
Merge pull request #587 from rosenbjerg/ensure-test-context-cancellationtoken-is-used
Ensure TestContext.CancellationToken is used
2025-10-18 00:01:15 +02:00
Malte Rosenbjerg
90786394a6 Increase timeout due to slow windows CI agent ... 2025-10-17 23:49:53 +02:00
Malte Rosenbjerg
9a0f784c71 Increate timeout further due to slow windows CI .... 2025-10-17 23:29:13 +02:00
Malte Rosenbjerg
90be0888e8 Create BaseTimeoutMilliseconds in AudioTests 2025-10-17 23:15:28 +02:00
Malte Rosenbjerg
f11b168ed9 Increase timeout because of slow windows CI agents 2025-10-17 23:15:16 +02:00
Malte Rosenbjerg
d0f6db1a2a Dont override in test using cancellationtoken 2025-10-17 22:52:33 +02:00
Malte Rosenbjerg
40414ad008 Remove extranous blank line 2025-10-17 22:46:45 +02:00
Malte Rosenbjerg
0ea445cdb8 Apply suggestions from Copilot review 2025-10-17 22:46:03 +02:00
Malte Rosenbjerg
326b3e2719 Use local CancellationTokenSource 2025-10-17 22:43:25 +02:00
Malte Rosenbjerg
fab7ff0aab Ensure TestContext.CancellationToken is used 2025-10-17 22:37:39 +02:00
Malte Rosenbjerg
2003100909 Improve test for percentage progress events 2025-10-17 22:14:00 +02:00
Malte Rosenbjerg
0d07456c6e
Merge pull request #584 from rosenbjerg/improve-cancellation-handling
Improve cancellation handling
2025-10-17 22:12:50 +02:00
Malte Rosenbjerg
34a9174b90
Merge pull request #583 from rosenbjerg/fix-GetCreationTime-function
Fix GetCreationTime
2025-10-17 21:57:10 +02:00
Malte Rosenbjerg
d890429269 Remove extranous blank line 2025-10-17 21:56:40 +02:00
Malte Rosenbjerg
670986dcb2 Extract method for reuse 2025-10-17 21:54:19 +02:00
Malte Rosenbjerg
7c070765b8 Remove stray space 2025-10-17 21:51:43 +02:00
Malte Rosenbjerg
4baddaab7f Add test verifying cancellation before processing starts 2025-10-17 21:51:11 +02:00
Malte Rosenbjerg
6b1e34ce08 Change fps parameter to double 2025-10-17 21:50:49 +02:00
Malte Rosenbjerg
3c3da28a99 Update test assertion on video duration 2025-10-17 21:50:34 +02:00
Malte Rosenbjerg
0f800c4333 Provide fps argument to input parameter as well 2025-10-17 21:49:42 +02:00
Malte Rosenbjerg
e01b73787d Improve cancellation handling 2025-10-17 21:48:30 +02:00
Malte Rosenbjerg
fc5e8a66e3 Prep for release 2025-10-17 20:36:58 +02:00
Malte Rosenbjerg
46fb46381d
Merge pull request #581 from rosenbjerg/include-more-guid-chars-in-pipe-path
Include more guid chars in pipe path
2025-10-17 20:34:45 +02:00
Malte Rosenbjerg
77d13e8143
Update FFMpegCore.Test/ArgumentBuilderTest.cs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-10-17 19:54:15 +02:00
Malte Rosenbjerg
1b0051b234 Create variable for holding macOS max pipe path length to avoid magic number 2025-10-17 19:53:38 +02:00
Malte Rosenbjerg
f0b5859afd Add test verifying that full pipe path is less than maximum pipe path length on macos 2025-10-17 19:47:41 +02:00