From 2a16824e69cdc16dc4f5fd8caccf3a7243159b96 Mon Sep 17 00:00:00 2001 From: Malte Rosenbjerg Date: Mon, 27 Oct 2025 20:43:56 +0100 Subject: [PATCH 1/2] Fix changing of output extension in BaseSubVideo --- FFMpegCore/FFMpeg/FFMpeg.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FFMpegCore/FFMpeg/FFMpeg.cs b/FFMpegCore/FFMpeg/FFMpeg.cs index b9a0d5d..6a6d8c8 100644 --- a/FFMpegCore/FFMpeg/FFMpeg.cs +++ b/FFMpegCore/FFMpeg/FFMpeg.cs @@ -297,7 +297,7 @@ public static class FFMpeg { if (Path.GetExtension(input) != Path.GetExtension(output)) { - output = Path.Combine(Path.GetDirectoryName(output), Path.GetFileNameWithoutExtension(output), Path.GetExtension(input)); + output = Path.ChangeExtension(output, Path.GetExtension(input)); } return FFMpegArguments From 1442c08e374cfc9a8e29bf4edcbdb84761113400 Mon Sep 17 00:00:00 2001 From: Malte Rosenbjerg Date: Mon, 27 Oct 2025 21:03:24 +0100 Subject: [PATCH 2/2] Lower amount of bitmaps used in tests --- FFMpegCore.Test/VideoTest.cs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/FFMpegCore.Test/VideoTest.cs b/FFMpegCore.Test/VideoTest.cs index b0a85aa..c441d13 100644 --- a/FFMpegCore.Test/VideoTest.cs +++ b/FFMpegCore.Test/VideoTest.cs @@ -154,7 +154,7 @@ public class VideoTest { using var outputFile = new TemporaryFile($"out{VideoType.Mp4.Extension}"); - var videoFramesSource = new RawVideoPipeSource(BitmapSource.CreateBitmaps(128, pixelFormat, 256, 256)); + var videoFramesSource = new RawVideoPipeSource(BitmapSource.CreateBitmaps(64, pixelFormat, 256, 256)); var success = FFMpegArguments .FromPipeInput(videoFramesSource) .OutputToFile(outputFile, false, opt => opt @@ -474,7 +474,7 @@ public class VideoTest private static async Task Video_ToTS_Args_Pipe_Internal(dynamic pixelFormat, CancellationToken cancellationToken) { using var output = new TemporaryFile($"out{VideoType.Ts.Extension}"); - var input = new RawVideoPipeSource(BitmapSource.CreateBitmaps(128, pixelFormat, 256, 256)); + var input = new RawVideoPipeSource(BitmapSource.CreateBitmaps(64, pixelFormat, 256, 256)); var success = await FFMpegArguments .FromPipeInput(input) @@ -511,7 +511,7 @@ public class VideoTest public void RawVideoPipeSource_Ogv_Scale(SKColorType pixelFormat) { using var outputFile = new TemporaryFile($"out{VideoType.Ogv.Extension}"); - var videoFramesSource = new RawVideoPipeSource(BitmapSource.CreateBitmaps(128, pixelFormat, 256, 256)); + var videoFramesSource = new RawVideoPipeSource(BitmapSource.CreateBitmaps(64, pixelFormat, 256, 256)); FFMpegArguments .FromPipeInput(videoFramesSource) @@ -565,7 +565,7 @@ public class VideoTest private static void Video_ToMP4_Resize_Args_Pipe_Internal(dynamic pixelFormat, CancellationToken cancellationToken) { using var outputFile = new TemporaryFile($"out{VideoType.Mp4.Extension}"); - var videoFramesSource = new RawVideoPipeSource(BitmapSource.CreateBitmaps(128, pixelFormat, 256, 256)); + var videoFramesSource = new RawVideoPipeSource(BitmapSource.CreateBitmaps(64, pixelFormat, 256, 256)); var success = FFMpegArguments .FromPipeInput(videoFramesSource) @@ -927,7 +927,7 @@ public class VideoTest { using var resStream = new MemoryStream(); var reader = new StreamPipeSink(resStream); - var writer = new RawVideoPipeSource(BitmapSource.CreateBitmaps(128, pixelFormat, 128, 128)); + var writer = new RawVideoPipeSource(BitmapSource.CreateBitmaps(64, pixelFormat, 128, 128)); FFMpegArguments .FromPipeInput(writer)