Alex/FFMpegCore
1
0
Fork 0
mirror of https://github.com/rosenbjerg/FFMpegCore.git synced 2025-12-14 10:05:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #1 from alahane-techtel/alahane-techtel-patch-1/NamedPipeCleanupRaceCondition

Browse source 
Fixed race condition on Named pipe dispose/disconnect
This commit is contained in:
Ashish 2025-07-07 17:04:39 +10:00 • committed by GitHub
commit 67808c2e4a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 14 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
FFMpegCore/FFMpeg/Arguments/PipeArgument.cs
View file

@ -31,8 +31,12 @@ namespace FFMpegCore.Arguments
public void Post() public void Post()
{ {
Debug.WriteLine($"Disposing NamedPipeServerStream on {GetType().Name}"); Debug.WriteLine($"Disposing NamedPipeServerStream on {GetType().Name}");
Pipe?.Dispose(); lock(Pipe)
Pipe = null!; {
Pipe?.Dispose();
Pipe = null!;
}
} }
public async Task During(CancellationToken cancellationToken = default) public async Task During(CancellationToken cancellationToken = default)
@ -48,9 +52,15 @@ namespace FFMpegCore.Arguments
finally finally
{ {
Debug.WriteLine($"Disconnecting NamedPipeServerStream on {GetType().Name}"); Debug.WriteLine($"Disconnecting NamedPipeServerStream on {GetType().Name}");
if (Pipe is { IsConnected: true }) lock (Pipe ?? new object())
//if Pipe is null, then the lock doesnt matter,
//Because the next code will not execute anyways.
//so we can use a new object
{ {
Pipe.Disconnect(); if (Pipe is { IsConnected: true })
{
Pipe.Disconnect();
}
} }
} }
} }