From 20031009096f75a4f673bb22bd081cd997076f34 Mon Sep 17 00:00:00 2001 From: Malte Rosenbjerg Date: Fri, 17 Oct 2025 22:14:00 +0200 Subject: [PATCH 1/2] Improve test for percentage progress events --- FFMpegCore.Test/VideoTest.cs | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/FFMpegCore.Test/VideoTest.cs b/FFMpegCore.Test/VideoTest.cs index 7946552..295f751 100644 --- a/FFMpegCore.Test/VideoTest.cs +++ b/FFMpegCore.Test/VideoTest.cs @@ -785,12 +785,12 @@ public class VideoTest var timeDone = TimeSpan.Zero; var analysis = FFProbe.Analyse(TestResources.Mp4Video); + var events = new List(); + void OnPercentageProgess(double percentage) { - if (percentage < 100) - { - percentageDone = percentage; - } + events.Add(percentage); + percentageDone = percentage; } void OnTimeProgess(TimeSpan time) @@ -812,7 +812,9 @@ public class VideoTest Assert.IsTrue(success); Assert.IsTrue(File.Exists(outputFile)); Assert.AreNotEqual(0.0, percentageDone); - Assert.AreNotEqual(100.0, percentageDone); + CollectionAssert.AllItemsAreUnique(events); + Assert.AreNotEqual(100.0, events.First()); + Assert.AreEqual(100.0, events.Last()); Assert.AreNotEqual(TimeSpan.Zero, timeDone); Assert.AreNotEqual(analysis.Duration, timeDone); } From 0ea445cdb8be9384ad322d3c5e3bf87e907023de Mon Sep 17 00:00:00 2001 From: Malte Rosenbjerg Date: Fri, 17 Oct 2025 22:46:03 +0200 Subject: [PATCH 2/2] Apply suggestions from Copilot review --- FFMpegCore.Test/VideoTest.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/FFMpegCore.Test/VideoTest.cs b/FFMpegCore.Test/VideoTest.cs index 295f751..46161ae 100644 --- a/FFMpegCore.Test/VideoTest.cs +++ b/FFMpegCore.Test/VideoTest.cs @@ -812,9 +812,10 @@ public class VideoTest Assert.IsTrue(success); Assert.IsTrue(File.Exists(outputFile)); Assert.AreNotEqual(0.0, percentageDone); + Assert.IsGreaterThan(1, events.Count); CollectionAssert.AllItemsAreUnique(events); Assert.AreNotEqual(100.0, events.First()); - Assert.AreEqual(100.0, events.Last()); + Assert.AreEqual(100.0, events.Last(), 0.001); Assert.AreNotEqual(TimeSpan.Zero, timeDone); Assert.AreNotEqual(analysis.Duration, timeDone); }